Make symbolize keys optional #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is a resubmission of #362 |
bastelfreak
force-pushed
the
optional-symbolize-keys
branch
2 times, most recently
from
9b8742b to
d55cbf4
Compare
bastelfreak
commented
Jun 7, 2024
bastelfreak
force-pushed
the
optional-symbolize-keys
branch
from
d55cbf4 to
dd4a60d
Compare
|
I would like to merge this in the next minor release, then do a major one without legacy facts and flip the default to factsets aren't symbolized anymore. Objections? |
bastelfreak
force-pushed
the
optional-symbolize-keys
branch
from
dd4a60d to
ca8070d
Compare
This was referenced Jun 7, 2024
silug
approved these changes
Jun 7, 2024
This was referenced Jun 8, 2024
rspec-puppet-facts has a setting to stringify keys again. Converting to symbols and then converting back to strings is inefficient. This parameter allows skipping the step.
bastelfreak
force-pushed
the
optional-symbolize-keys
branch
from
ca8070d to
880b135
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rspec-puppet-facts has a setting to stringify keys again. Converting to symbols and then converting back to strings is inefficient. This parameter allows skipping the step.